chore: update snippets for Maps 3D SDK compatibility#25
Merged
Conversation
Collaborator
|
Not attributable to this PR, but we could think of modularising all individual projects, to make mainteinance easier. |
kikoso
reviewed
Feb 18, 2026
| google() | ||
| mavenCentral() | ||
| maven { | ||
| url = uri("/Users/dkhawk/AndroidStudioProjects/github-maps-code/android-maps3d-samples/feat-update-library-version/local-maven-repo") |
Collaborator
There was a problem hiding this comment.
We would need to remove this or use a different placeholder before merging it, right?
kikoso
reviewed
Feb 18, 2026
CATALOG.md
Outdated
| @@ -0,0 +1,1033 @@ | |||
| # Snippets Catalog | |||
Collaborator
There was a problem hiding this comment.
Should this file go inside the snippets folder?
kikoso
reviewed
Feb 18, 2026
| ) | ||
| } | ||
|
|
||
| private fun configureMap(map: GoogleMap3D) { |
Collaborator
There was a problem hiding this comment.
Do we need any configuration here?
kikoso
reviewed
Feb 18, 2026
snippets/catalog_generator.py
Outdated
| content_lines = [] | ||
| valid_line = True | ||
| if tag == "maps_android_3d_camera_events_java": | ||
| print(f"DEBUG: Processing {tag}. Total lines captured: {len(snippet_data['lines'])}") |
Collaborator
There was a problem hiding this comment.
nit: this debug statements can be configured with Python built-in logging module.
kikoso
reviewed
Feb 18, 2026
| roll = 0.0 | ||
| range = 2000.0 | ||
| } | ||
| // LINT.ThenChange(//depot/google3/java/com/google/android/gmscore/integ/testapps/maps3d/basic/res/layout/main.xml) |
Collaborator
There was a problem hiding this comment.
This probably needs to be removed before merging, right?
kikoso
reviewed
Feb 18, 2026
| // LINT.ThenChange(//depot/google3/java/com/google/android/gmscore/integ/testapps/maps3d/basic/res/layout/main.xml) | ||
|
|
||
| flyToButton.setOnClickListener { | ||
| Log.d("MainActivity", "flyToButton clicked") |
Collaborator
There was a problem hiding this comment.
What about adding a TAG for all these logs?
dkhawk
force-pushed
the
feat/snippets-updates
branch
from
c252aa4 to
6ea5a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates snippets to be compatible with Maps 3D SDK v0.2.0.
Changes:
positiontopositionAnchorin Popover.autoCloseEnabledandautoPanEnabledproperty names.